Discussion:
[tryton] bug in carrier-weight ?
JC Michel
2018-05-15 08:51:41 UTC
Permalink
Hi,


When using carrier-weight to compute an invoice line for a carrier
depending on weight:
when coming back, in Sale, to Draft state to edit the Carrier, the
generated carrier invoice line is not deleted,
and creates an error
File "/trytond/modules/sale_shipment_cost/sale.py", line 207, in
set_shipment_cost
with Transaction().set_context(self._get_carrier_context()):
File "/trytond/modules/carrier_weight/sale.py", line 33, in
_get_carrier_context
lines = sorted(lines, key=keyfunc)
TypeError: unorderable types: NoneType() < NoneType()

Seems that the carrier line doesn’t have a weight!
Deleting manually the invoice line seems to fix this.
IMHO the carrier line should be deleted when going back in Draft state.
Should I open a bug?

PS : tryton version 4.6

Jean-Christophe Michel
\--
![SYMÉTRIE, livres et
partitions](Loading Image... "SYMÉTRIE")
---
30 rue Jean-Baptiste Say
69001 LYON
FRANCE

[www.symetrie.com](<https://symetrie.com>)

[![www.facebook.com/symetrie](Loading Image...)](<http://facebook.com/symetrie>)
|
[![www.twitter.com/symetriecom](Loading Image...)](<http://twitter.com/symetriecom>)
|
[![www.linkedin.com/company/symetrie-music-publisher](Loading Image...)](<http://www.linkedin.com/company/symetrie-music-publisher>)

tél : +33 (0) 478 29 52 14
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/4CD16F9A-49E1-4E41-9F0C-C1443E8B27B8%40symetrie.com.
Sergi Almacellas Abellana
2018-05-15 11:20:58 UTC
Permalink
Post by JC Michel
Hi,
When using carrier-weight to compute an invoice line for a carrier
when coming back, in Sale, to Draft state to edit the Carrier, the
generated carrier invoice line is not deleted,
and creates an error
File "/trytond/modules/sale_shipment_cost/sale.py", line 207, in
set_shipment_cost
File "/trytond/modules/carrier_weight/sale.py", line 33, in
_get_carrier_context
lines = sorted(lines, key=keyfunc)
TypeError: unorderable types: NoneType() < NoneType()
Seems that the carrier line doesn’t have a weight!
Deleting manually the invoice line seems to fix this.
IMHO the carrier line should be deleted when going back in Draft state.
Should I open a bug?
Yes, you should open a bug with the steps to reproduce it on a fresh
database and with the stack trace generated.
Post by JC Michel
PS : tryton version 4.6
It seems that you are also using python3 version. It will be great if
you can confirm it on the issue.
Post by JC Michel
Jean-Christophe Michel
--
SYMÉTRIE, livres et partitions
30 rue Jean-Baptiste Say
69001 LYON
FRANCE
www.symetrie.com <https://symetrie.com>
www.facebook.com/symetrie <http://facebook.com/symetrie> |
www.twitter.com/symetriecom <http://twitter.com/symetriecom> |
www.linkedin.com/company/symetrie-music-publisher
<http://www.linkedin.com/company/symetrie-music-publisher>
tél : +33 (0) 478 29 52 14
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit
https://groups.google.com/d/msgid/tryton/4CD16F9A-49E1-4E41-9F0C-C1443E8B27B8%40symetrie.com
<https://groups.google.com/d/msgid/tryton/4CD16F9A-49E1-4E41-9F0C-C1443E8B27B8%40symetrie.com?utm_medium=email&utm_source=footer>.
--
Sergi Almacellas Abellana
www.koolpi.com
Twitter: @pokoli_srk
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/d8ab9510-4480-e2d4-50e6-5a1f0152fb74%40koolpi.com.
Continue reading on narkive:
Loading...