Discussion:
[tryton] Usage of Spanish accounting module
Cédric Krier
2018-03-20 16:08:55 UTC
Permalink
Hi,

In the last release 4.6, we included a module for the Spanish
accounting. But it showed that there was many issues with its design:
https://bugs.tryton.org/issue7150

Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.

Also, it is currently blocking https://bugs.tryton.org/issue6013

So I'm wondering who is using it currently?
--
Cédric Krier - B2CK SPRL
Email/Jabber: ***@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/20180320160855.GV3935%40kei.
Gonzalo González Domínguez
2018-03-20 18:37:31 UTC
Permalink
Post by Cédric Krier
Hi,
In the last release 4.6, we included a module for the Spanish
https://bugs.tryton.org/issue7150
Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.
Also, it is currently blocking https://bugs.tryton.org/issue6013
So I'm wondering who is using it currently?
--
Cédric Krier - B2CK SPRL
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
We use it, but not yet in production
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/f627d1c3-b4e6-4bda-95ea-621e4718288f%40googlegroups.com.
Cédric Krier
2018-03-20 19:28:18 UTC
Permalink
Post by Cédric Krier
In the last release 4.6, we included a module for the Spanish
https://bugs.tryton.org/issue7150
Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.
Also, it is currently blocking https://bugs.tryton.org/issue6013
I must also add that we receive issue which are hard to understand
without proper documentation:

https://bugs.tryton.org/issue7066
https://bugs.tryton.org/issue7077
Post by Cédric Krier
So I'm wondering who is using it currently?
--
Cédric Krier - B2CK SPRL
Email/Jabber: ***@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/20180320192818.GD3935%40kei.
Raimon Esteve
2018-03-20 20:42:27 UTC
Permalink
Hello

El dia 20 març 2018 5:10 p. m., "Cédric Krier" <***@b2ck.com> va
escriure:

Hi,

In the last release 4.6, we included a module for the Spanish
accounting. But it showed that there was many issues with its design:
https://bugs.tryton.org/issue7150

Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.


Not LGTM

You can't simplicy account_es module because an account user need all
information about taxes and accounts.

A not spanish account user is difficult to understand. All information is
published in BOE for each change (laws) . There are not documentation or a
link to download.

Last version (4.7), all AEAT modules are new feature to working with
account_es from core. Also, we do support account_es_normal (oldest
account_es) and account_es_pyme from trytonspain. Trytonspain modules, have
extra features (recargo equivalÚncia, deducible, SII, etc)

In case we can't find those taxes and accounts in account_es, we need to
create third modules to add it.

Sincerently, I prefer continue to working account_es from trytonspain and
mark deprecated account_es core module.

Regards,



Also, it is currently blocking https://bugs.tryton.org/issue6013

So I'm wondering who is using it currently?

--
Cédric Krier - B2CK SPRL
Email/Jabber: ***@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/

--
You received this message because you are subscribed to the Google Groups
"tryton" group.
To view this discussion on the web visit https://groups.google.com/d/
msgid/tryton/20180320160855.GV3935%40kei.
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/CAN2HbXVZMPxdd-SYm8%3Do5766_HaYkLBQJtvOrCzZv%2BjxL-z0FQ%40mail.gmail.com.
Cédric Krier
2018-03-20 21:37:54 UTC
Permalink
Post by Cédric Krier
In the last release 4.6, we included a module for the Spanish
https://bugs.tryton.org/issue7150
Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.
Not LGTM
I'm not asking for permission here. I'm just warning about the situation
and the ending if nothing changes.
Post by Cédric Krier
You can't simplicy account_es module because an account user need all
information about taxes and accounts.
Did you read the issue? The actual module contains very wrong and poor
configuration.
And I doubt about the general purpose of many accounts and taxes.
Spain can not need twice more than France and Germany and three times
more than Belgium.
Country modules should contain only general purpose configuration and
not every tiny needs of any users.
Post by Cédric Krier
A not spanish account user is difficult to understand. All information is
published in BOE for each change (laws) . There are not documentation or a
link to download.
But you had access at some point to the information otherwise how did
you create this module?
Post by Cédric Krier
Last version (4.7), all AEAT modules are new feature to working with
account_es from core.
What are you talking about?
Post by Cédric Krier
Also, we do support account_es_normal (oldest
account_es) and account_es_pyme from trytonspain.
I have explained many years ago why it was a bad idea to manage multiple
modules. (But only pokoli took the time to try to provide a correct
implementation).
Post by Cédric Krier
Trytonspain modules, have extra features (recargo equivalència,
deducible, SII, etc)
What are those features?
Post by Cédric Krier
In case we can't find those taxes and accounts in account_es, we need to
create third modules to add it.
I do not understand. What is missing? Is it really for general purpose?
As usual no useful information.
Post by Cédric Krier
Sincerently, I prefer continue to working account_es from trytonspain and
mark deprecated account_es core module.
This is very sad to see such non-collaborative behaviour.
Most of the issues you fill have no explanation. So it is not possible
to judge the correctness.
So if I can not have a collaborative team working on making a *good*
Spanish accounting implementation, there will be no choice than dropping
it support.


PS: this is again a perfect example that modules created outside Tryton
process have all the pain to come back in standard.
--
Cédric Krier - B2CK SPRL
Email/Jabber: ***@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/20180320213754.GE3935%40kei.
Sergi Almacellas Abellana
2018-03-21 10:05:31 UTC
Permalink
Post by Cédric Krier
Post by Cédric Krier
In the last release 4.6, we included a module for the Spanish
https://bugs.tryton.org/issue7150
Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.
Not LGTM
I'm not asking for permission here. I'm just warning about the situation
and the ending if nothing changes.
Post by Cédric Krier
You can't simplicy account_es module because an account user need all
information about taxes and accounts.
We can simplify the account_es and let the user manually create extra
account/taxes if they use it. We already do it for accounts. For taxes
the spanish comunity always tried to get all the taxes on the chart of
account module but this results with having more taxes unused that the
ones that the user really needs. And for me this is wrong as it only
causes confusion.
Post by Cédric Krier
Post by Cédric Krier
Trytonspain modules, have extra features (recargo equivalència,
deducible, SII, etc)
What are those features?
The account_es already contains the recargo de equivalencia taxes
definition. Indeed a new feature was introduced on tryton to support
this case. [1]

The SII is a separate functionality out of the scope of the chart of
accounts. For those curious SII is a webservice which is used to send
the invoices (with taxes) information to tax authority. This is only
required for companies above a revenue threshold (4M€ IIRC).

Raimon: Could you explain what do you mean about deducible and which
functionalities are implemented?
Post by Cédric Krier
Post by Cédric Krier
Sincerently, I prefer continue to working account_es from trytonspain and
mark deprecated account_es core module.
It's a pity to read those words. I can understand that people thinks
it's easier to stay on their comfort zone. But for sure it's better to
move outside of it and improve tryton.
Post by Cédric Krier
This is very sad to see such non-collaborative behaviour.
Most of the issues you fill have no explanation. So it is not possible
to judge the correctness.
And most of them end with unasked questions. Just to have it clear: I
will be happy to help resolving the issues but I can not do it without
understanding the problem. Sometimes I think it's a communication
problem (due to language or written expression, not sure). I'm open to
other communication methods if this will help to resolve the issues.
Post by Cédric Krier
PS: this is again a perfect example that modules created outside Tryton
process have all the pain to come back in standard.
I hope others will learn from the pain we are suffering here. This topic
is worth a talk on the next unconference :)

[1]
https://discuss.tryton.org/t/preserve-original-tax-when-appling-tax-rules/397/12
--
Sergi Almacellas Abellana
www.koolpi.com
Twitter: @pokoli_srk
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/7ab11a9d-0c79-2830-3d4d-8754fd5f6a25%40koolpi.com.
Raimon Esteve
2018-03-21 10:18:08 UTC
Permalink
Post by Sergi Almacellas Abellana
Post by Cédric Krier
Post by Cédric Krier
In the last release 4.6, we included a module for the Spanish
https://bugs.tryton.org/issue7150
Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.
Not LGTM
I'm not asking for permission here. I'm just warning about the situation
and the ending if nothing changes.
Post by Cédric Krier
You can't simplicy account_es module because an account user need all
information about taxes and accounts.
We can simplify the account_es and let the user manually create extra
account/taxes if they use it. We already do it for accounts. For taxes
the spanish comunity always tried to get all the taxes on the chart of
account module but this results with having more taxes unused that the
ones that the user really needs. And for me this is wrong as it only
causes confusion.
Post by Cédric Krier
Post by Cédric Krier
Trytonspain modules, have extra features (recargo equivalència,
deducible, SII, etc)
What are those features?
The account_es already contains the recargo de equivalencia taxes
definition. Indeed a new feature was introduced on tryton to support
this case. [1]
The SII is a separate functionality out of the scope of the chart of
accounts. For those curious SII is a webservice which is used to send
the invoices (with taxes) information to tax authority. This is only
required for companies above a revenue threshold (4M€ IIRC).
Raimon: Could you explain what do you mean about deducible and which
functionalities are implemented?
First design account_es module:

https://bitbucket.org/trytonspain/trytond-account_es/src/

Third modules to add more functions in account_es core module (from tryton.org):

https://bitbucket.org/trytonspain/trytond-account_es_es/src/

All of then, generated from csv2xml:

https://bitbucket.org/trytonspain/tryton-account_es_csv2xml

Regards.
Post by Sergi Almacellas Abellana
Post by Cédric Krier
Post by Cédric Krier
Sincerently, I prefer continue to working account_es from trytonspain and
mark deprecated account_es core module.
It's a pity to read those words. I can understand that people thinks
it's easier to stay on their comfort zone. But for sure it's better to
move outside of it and improve tryton.
Post by Cédric Krier
This is very sad to see such non-collaborative behaviour.
Most of the issues you fill have no explanation. So it is not possible
to judge the correctness.
And most of them end with unasked questions. Just to have it clear: I
will be happy to help resolving the issues but I can not do it without
understanding the problem. Sometimes I think it's a communication
problem (due to language or written expression, not sure). I'm open to
other communication methods if this will help to resolve the issues.
Post by Cédric Krier
PS: this is again a perfect example that modules created outside Tryton
process have all the pain to come back in standard.
I hope others will learn from the pain we are suffering here. This topic
is worth a talk on the next unconference :)
[1]
https://discuss.tryton.org/t/preserve-original-tax-when-appling-tax-rules/397/12
--
Sergi Almacellas Abellana
www.koolpi.com
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/7ab11a9d-0c79-2830-3d4d-8754fd5f6a25%40koolpi.com.
--
Si us plau, NO adjunti arxius a les seves respostes. Li preguem que
integri el text al cos del missatge. Pot respondre usant NetEtiquete
que li ajudarà a seguir la conversa.
http://es.wikipedia.org/wiki/Netiquette

Por favor, NO adjunte archivos a sus respuestas. Le rogamos que
integre el texto en el cuerpo del mensaje. Puede responder usando
NetEtiquete que le ayudará a seguir la
conversación.http://es.wikipedia.org/wiki/Netiquette

Please, DO NOT send attachment files with your answers, just copy and
paste only the text you need to send into the body of your mails.
Repply using NetEtiquete. http://en.wikipedia.org/wiki/Netiquette
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/CAN2HbXWymCYN4%2BAEncpwnXNsaK6XYyQnRHUHpdyq22rdALRfEA%40mail.gmail.com.
Sergi Almacellas Abellana
2018-03-21 10:37:35 UTC
Permalink
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
Raimon: Could you explain what do you mean about deducible and which
functionalities are implemented?
https://bitbucket.org/trytonspain/trytond-account_es/src/
That's the base we picked for the first version of the account_es
module. We did some cleaning and as already explained on this thread we
should do more cleaning.
Post by Raimon Esteve
https://bitbucket.org/trytonspain/trytond-account_es_es/src/
Let's comment the functionality added by this module.

- It adds and efective kind on account. Where is the efective kind used?
If any module requires a new kind it should be added on the module and
not on a chart of accounts (Like we do in account_deposit). Indeed there
is an issue to allow to define the kind depending on the activated
modules: https://bugs.tryton.org/issue7126

- It adds the code on fiscalyear and period. This was removed by
https://bugs.tryton.org/issue4241 Could you explain why is required to
have the code on the spanish localization. I don't see any reason here.

- It removes the xml check from the template modules. Why is this
required? IIRC this is a workarround to solve another problem and should
not be part of the chart of accounts.

- It adds a report description on the taxes. This is already implemented
with https://bugs.tryton.org/issue2329

- It adds a deducible boolean on the taxes. I see all have the value of
True. So could you explain why this flag is needed and which taxes will
have a False value?

- It adds a recargo equivalencia flag to the taxes. This flag is not set
for any taxes (but we have the recargo the equivalencia base module). So
I do not think this is a used feature and it can be removed.

Thanks for your time.
--
Sergi Almacellas Abellana
www.koolpi.com
Twitter: @pokoli_srk
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/353c90e6-9049-d1d4-b11b-6b8a8b42d002%40koolpi.com.
Raimon Esteve
2018-03-21 10:55:21 UTC
Permalink
Post by Sergi Almacellas Abellana
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
Raimon: Could you explain what do you mean about deducible and which
functionalities are implemented?
https://bitbucket.org/trytonspain/trytond-account_es/src/
That's the base we picked for the first version of the account_es
module. We did some cleaning and as already explained on this thread we
should do more cleaning.
Post by Raimon Esteve
https://bitbucket.org/trytonspain/trytond-account_es_es/src/
Let's comment the functionality added by this module.
- It adds and efective kind on account. Where is the efective kind used?
If any module requires a new kind it should be added on the module and
not on a chart of accounts (Like we do in account_deposit). Indeed there
is an issue to allow to define the kind depending on the activated
modules: https://bugs.tryton.org/issue7126
https://bitbucket.org/trytonspain/trytond-account_es/commits/ad96bde5798318763e303caa6becd4470e33c4a3
Post by Sergi Almacellas Abellana
- It adds the code on fiscalyear and period. This was removed by
https://bugs.tryton.org/issue4241 Could you explain why is required to
have the code on the spanish localization. I don't see any reason here.
Code field was removed from account module last versions. We use in
aeat modules, etc.
Post by Sergi Almacellas Abellana
- It removes the xml check from the template modules. Why is this
required? IIRC this is a workarround to solve another problem and should
not be part of the chart of accounts.
to allow update account.template etc
Post by Sergi Almacellas Abellana
- It adds a report description on the taxes. This is already implemented
with https://bugs.tryton.org/issue2329
Is not same legal notice that report description tax.
Post by Sergi Almacellas Abellana
- It adds a deducible boolean on the taxes. I see all have the value of
True. So could you explain why this flag is needed and which taxes will
have a False value?
https://bitbucket.org/trytonspain/tryton-account_es_csv2xml/commits/a85b54392424eeb8be4b404e46aeaacbfb27ae7b
Post by Sergi Almacellas Abellana
- It adds a recargo equivalencia flag to the taxes. This flag is not set
for any taxes (but we have the recargo the equivalencia base module). So
I do not think this is a used feature and it can be removed.
https://bitbucket.org/trytonspain/tryton-account_es_csv2xml/commits/492a29cbc17b1590c10763d9629a07d65f0d01b0

note:
@sergi, you was working on trytonspain modules some years ago. I think
you know/remember very well all features and desings, and why do
it,.... ;)

I have two new quesions to know future about account_es module:

- Who know account chart account? spanish account users or foreign users?
- I read about the idea to do a basic module with a simple data and
remove extra data that need medium/big companies. Correct?
Post by Sergi Almacellas Abellana
Thanks for your time.
--
Sergi Almacellas Abellana
www.koolpi.com
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/353c90e6-9049-d1d4-b11b-6b8a8b42d002%40koolpi.com.
--
Si us plau, NO adjunti arxius a les seves respostes. Li preguem que
integri el text al cos del missatge. Pot respondre usant NetEtiquete
que li ajudarà a seguir la conversa.
http://es.wikipedia.org/wiki/Netiquette

Por favor, NO adjunte archivos a sus respuestas. Le rogamos que
integre el texto en el cuerpo del mensaje. Puede responder usando
NetEtiquete que le ayudará a seguir la
conversación.http://es.wikipedia.org/wiki/Netiquette

Please, DO NOT send attachment files with your answers, just copy and
paste only the text you need to send into the body of your mails.
Repply using NetEtiquete. http://en.wikipedia.org/wiki/Netiquette
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/CAN2HbXVGb4ULFJSnw13MvJ%3Dx8_LYtV7XqWK938b0uvq-09fUmQ%40mail.gmail.com.
Cédric Krier
2018-03-21 11:37:04 UTC
Permalink
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
Raimon: Could you explain what do you mean about deducible and which
functionalities are implemented?
https://bitbucket.org/trytonspain/trytond-account_es/src/
That's the base we picked for the first version of the account_es
module. We did some cleaning and as already explained on this thread we
should do more cleaning.
Post by Raimon Esteve
https://bitbucket.org/trytonspain/trytond-account_es_es/src/
Let's comment the functionality added by this module.
- It adds and efective kind on account. Where is the efective kind used?
If any module requires a new kind it should be added on the module and
not on a chart of accounts (Like we do in account_deposit). Indeed there
is an issue to allow to define the kind depending on the activated
modules: https://bugs.tryton.org/issue7126
https://bitbucket.org/trytonspain/trytond-account_es/commits/ad96bde5798318763e303caa6becd4470e33c4a3
I do not understand what you mean by pointing a link to commit.
Please elaborate a sentence to explain. Please try to be understood by
others.
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
- It adds the code on fiscalyear and period. This was removed by
https://bugs.tryton.org/issue4241 Could you explain why is required to
have the code on the spanish localization. I don't see any reason here.
Code field was removed from account module last versions. We use in
aeat modules, etc.
What is the usage? Why not use the name?
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
- It removes the xml check from the template modules. Why is this
required? IIRC this is a workarround to solve another problem and should
not be part of the chart of accounts.
to allow update account.template etc
I think this shows that current Spanish account template are wrong if
they need to be updated. And it is probably because there are too much.
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
- It adds a report description on the taxes. This is already implemented
with https://bugs.tryton.org/issue2329
Is not same legal notice that report description tax.
Please explain. What is the purpose? where is it used?
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
- It adds a deducible boolean on the taxes. I see all have the value of
True. So could you explain why this flag is needed and which taxes will
have a False value?
https://bitbucket.org/trytonspain/tryton-account_es_csv2xml/commits/a85b54392424eeb8be4b404e46aeaacbfb27ae7b
Again what do you want to express by pointing a commit of thousand of
lines?
Please try to have a conversation with arguments and explanation.
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
- It adds a recargo equivalencia flag to the taxes. This flag is not set
for any taxes (but we have the recargo the equivalencia base module). So
I do not think this is a used feature and it can be removed.
https://bitbucket.org/trytonspain/tryton-account_es_csv2xml/commits/492a29cbc17b1590c10763d9629a07d65f0d01b0
Again the same thousands of lines without any explanation.
Post by Raimon Esteve
@sergi, you was working on trytonspain modules some years ago. I think
you know/remember very well all features and desings, and why do
it,.... ;)
And for the others? How can we have explanation and design choices?
Post by Raimon Esteve
- Who know account chart account? spanish account users or foreign users?
I think keeping it secret only for you is not how to build a community.
Most of the challenge of accounting are not limited to a country as we
showed in many cases (cash basis, tax rule substitutions, invoice
sequences etc.). So yes "foreign developers" will probably improve the
Spanish chart of account (indeed https://bugs.tryton.org/issue7150
already prove it).
Post by Raimon Esteve
- I read about the idea to do a basic module with a simple data and
remove extra data that need medium/big companies. Correct?
This is the usual Tryton way. General usage is standard and specific
module for extended usage.
--
Cédric Krier - B2CK SPRL
Email/Jabber: ***@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/20180321113704.GG3935%40kei.
Sergi Almacellas Abellana
2018-03-21 12:21:37 UTC
Permalink
Post by Cédric Krier
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
Raimon: Could you explain what do you mean about deducible and which
functionalities are implemented?
https://bitbucket.org/trytonspain/trytond-account_es/src/
That's the base we picked for the first version of the account_es
module. We did some cleaning and as already explained on this thread we
should do more cleaning.
Post by Raimon Esteve
https://bitbucket.org/trytonspain/trytond-account_es_es/src/
Let's comment the functionality added by this module.
- It adds and efective kind on account. Where is the efective kind used?
If any module requires a new kind it should be added on the module and
not on a chart of accounts (Like we do in account_deposit). Indeed there
is an issue to allow to define the kind depending on the activated
modules: https://bugs.tryton.org/issue7126
https://bitbucket.org/trytonspain/trytond-account_es/commits/ad96bde5798318763e303caa6becd4470e33c4a3
I do not understand what you mean by pointing a link to commit.
Please elaborate a sentence to explain. Please try to be understood by
others.
I don't understand neither.

Just in case you are saing: "You added it on this commit on this day".
IIRC this was added but never fully implemented and that's why I think
it can be removed now.
Post by Cédric Krier
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
- It adds the code on fiscalyear and period. This was removed by
https://bugs.tryton.org/issue4241 Could you explain why is required to
have the code on the spanish localization. I don't see any reason here.
Code field was removed from account module last versions. We use in
aeat modules, etc.
What is the usage? Why not use the name?
The tax authority requires a numeric code of 4 digits to identify the
fiscalyear. Normally the year of the declaration is used. For me using a
code defined on the fiscalyear is wrong as it may be empty and it may
contain wrong values.
Post by Cédric Krier
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
- It removes the xml check from the template modules. Why is this
required? IIRC this is a workarround to solve another problem and should
not be part of the chart of accounts.
to allow update account.template etc
I think this shows that current Spanish account template are wrong if
they need to be updated. And it is probably because there are too much.
I don't see any need of update the templates and that's why it was
removed from the oficial proposal.

IIRC this was added in order to support another module that was used to
update the values of all companies when updating a tax. The customer had
a lot of companies an requested to allow to create accounts for all
companies from a single place.
Post by Cédric Krier
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
- It adds a report description on the taxes. This is already implemented
with https://bugs.tryton.org/issue2329
Is not same legal notice that report description tax.
Please explain. What is the purpose? where is it used?
The values used on the report description are the ones used on legal
notice. That's how we set the data on the 4.6 version of account_es.
Post by Cédric Krier
Post by Raimon Esteve
Post by Sergi Almacellas Abellana
- It adds a recargo equivalencia flag to the taxes. This flag is not set
for any taxes (but we have the recargo the equivalencia base module). So
I do not think this is a used feature and it can be removed.
https://bitbucket.org/trytonspain/tryton-account_es_csv2xml/commits/492a29cbc17b1590c10763d9629a07d65f0d01b0
Ok it was added but where is used? If it's not used there is no problem
to remove it.
Post by Cédric Krier
Again the same thousands of lines without any explanation.
Post by Raimon Esteve
@sergi, you was working on trytonspain modules some years ago. I think
you know/remember very well all features and desings, and why do
it,.... ;)
And for the others? How can we have explanation and design choices?
It will be great if others can join the conversation and explain their
needs.
Post by Cédric Krier
Post by Raimon Esteve
- Who know account chart account? spanish account users or foreign users?
I think keeping it secret only for you is not how to build a community.
Most of the challenge of accounting are not limited to a country as we
showed in many cases (cash basis, tax rule substitutions, invoice
sequences etc.). So yes "foreign developers" will probably improve the
Spanish chart of account (indeed https://bugs.tryton.org/issue7150
already prove it).
And also:

https://bugs.tryton.org/issue2329
https://bugs.tryton.org/issue6721
--
Sergi Almacellas Abellana
www.koolpi.com
Twitter: @pokoli_srk
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/094f56e4-d4f0-a4fa-9d4d-02985e24d804%40koolpi.com.
Sergi Almacellas Abellana
2018-03-21 09:36:23 UTC
Permalink
Post by Cédric Krier
Hi,
In the last release 4.6, we included a module for the Spanish
https://bugs.tryton.org/issue7150
Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.
Also, it is currently blocking https://bugs.tryton.org/issue6013
Of course I don't like the idea but I understand that we have the
feature freeze on the next week and I don't wanna rush this week.

As we are blocking other features I think the best option is to move to
the sandbox and improving the design for the next release.
Post by Cédric Krier
So I'm wondering who is using it currently?
We are using it but I don't mind manually applying some fixes if needed.
--
Sergi Almacellas Abellana
www.koolpi.com
Twitter: @pokoli_srk
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/c7c2e5c7-27ff-1a3d-83fb-3ccdfb502912%40koolpi.com.
Cédric Krier
2018-03-21 15:59:28 UTC
Permalink
Post by Cédric Krier
In the last release 4.6, we included a module for the Spanish
https://bugs.tryton.org/issue7150
Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.
I had a call with Sergi and we discussed about the module design etc.

We found that the tax code chart and the taxes need to have a cleaning
in depth. We will remove too specific stuffs (like agriculture taxes,
Canary special taxes etc.) to have a simpler but cleaner basis to built
on.

As it will take time and the release freeze is close, we will move the
module into sandbox and release it for 4.8 only when it is ready (so it
may be long after the fixed date).
As there are not much users of it now, we do not guarantee any migration
paths fro 4.6 to 4.8 for this module. (Sergi will maybe publish some
migration script later).

The removed features may be implemented later with extra modules like
account_es_agricultura or account_es_cn etc.
--
Cédric Krier - B2CK SPRL
Email/Jabber: ***@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/20180321155928.GJ3935%40kei.
Esteve Boix
2018-05-01 14:41:08 UTC
Permalink
I understand that if I have 4.6.0 installed with this module, I cannot upgrade (easily) to 4.8.0, am I right ?

I've tried the upgrade, but it clashes while doing the database update. I understand that this happens because Tryton is using functionality that is not present in 4.6's implementation of es ES chart of accounts module.

I'm not in production. This is just a test server to check if Tryton can fulfill our needs.
To upgrade, I did:

ALTER TABLE ir_lang ADD parent VARCHAR;

(as root)
pip install tryton trytond trytond-account trytond-account-eu trytond-account-invoice trytond-account-invoice-stock trytond-account-product trytond-company trytond-company-work-time trytond-country trytond-currency trytond-party trytond-product trytond-product-attribute trytond-product-price-list trytond-production trytond-production-routing trytond-production-work trytond-production-work-timesheet trytond-purchase trytond-sale trytond-sale-extra trytond-sale-opportunity trytond-sale-price-list trytond-stock trytond-timesheet --upgrade

...all fine and succesfully updated.
Then I try to update the database:

trytond-admin -c tryton/tryton.conf -d tryton --all
Traceback (most recent call last):
File "/usr/local/bin/trytond-admin", line 21, in <module>
admin.run(options)
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/admin.py", line 54, in run
installdeps=options.installdeps)
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/pool.py", line 144, in init
self.start()
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/pool.py", line 97, in start
register_classes()
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/modules/__init__.py", line 373, in register_classes
mod_file, pathname, description)
File "/usr/local/lib/python2.7/dist-packages/trytond/modules/currency/__init__.py", line 5, in <module>
from .currency import *
File "/usr/local/lib/python2.7/dist-packages/trytond/modules/currency/currency.py", line 11, in <module>
from trytond.model import (
ImportError: cannot import name DeactivableMixin

I'm stuck here.

Regards,
Esteve
Post by Cédric Krier
Post by Cédric Krier
In the last release 4.6, we included a module for the Spanish
https://bugs.tryton.org/issue7150
Currently, I'm envisaging to remove it from the standard modules (hide
the only release on PyPI) and move it to the sandbox repositories until
a proper design is found.
This way, we will be able to break migration path for it and restart it
with a good basis.
I had a call with Sergi and we discussed about the module design etc.
We found that the tax code chart and the taxes need to have a cleaning
in depth. We will remove too specific stuffs (like agriculture taxes,
Canary special taxes etc.) to have a simpler but cleaner basis to built
on.
As it will take time and the release freeze is close, we will move the
module into sandbox and release it for 4.8 only when it is ready (so it
may be long after the fixed date).
As there are not much users of it now, we do not guarantee any migration
paths fro 4.6 to 4.8 for this module. (Sergi will maybe publish some
migration script later).
The removed features may be implemented later with extra modules like
account_es_agricultura or account_es_cn etc.
--
Cédric Krier - B2CK SPRL
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/e4488557-46ab-4dac-aa8a-8d7576c8a9c3%40googlegroups.com.
Sergi Almacellas Abellana
2018-05-02 07:58:28 UTC
Permalink
Post by Esteve Boix
I understand that if I have 4.6.0 installed with this module, I cannot upgrade (easily) to 4.8.0, am I right ?
Well, you can upgrade without problems but all the taxes and accounts
that are removed on newer versions will not be removed from your
existing database. Otherwise everything works as expected.
Post by Esteve Boix
I've tried the upgrade, but it clashes while doing the database update. I understand that this happens because Tryton is using functionality that is not present in 4.6's implementation of es ES chart of accounts module.>
I'm not in production. This is just a test server to check if Tryton can fulfill our needs.
ALTER TABLE ir_lang ADD parent VARCHAR;
(as root)
pip install tryton trytond trytond-account trytond-account-eu trytond-account-invoice trytond-account-invoice-stock trytond-account-product trytond-company trytond-company-work-time trytond-country trytond-currency trytond-party trytond-product trytond-product-attribute trytond-product-price-list trytond-production trytond-production-routing trytond-production-work trytond-production-work-timesheet trytond-purchase trytond-sale trytond-sale-extra trytond-sale-opportunity trytond-sale-price-list trytond-stock trytond-timesheet --upgrade
...all fine and succesfully updated.
trytond-admin -c tryton/tryton.conf -d tryton --all
File "/usr/local/bin/trytond-admin", line 21, in <module>
admin.run(options)
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/admin.py", line 54, in run
installdeps=options.installdeps)
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/pool.py", line 144, in init
self.start()
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/pool.py", line 97, in start
register_classes()
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/modules/__init__.py", line 373, in register_classes
mod_file, pathname, description)
File "/usr/local/lib/python2.7/dist-packages/trytond/modules/currency/__init__.py", line 5, in <module>
from .currency import *
File "/usr/local/lib/python2.7/dist-packages/trytond/modules/currency/currency.py", line 11, in <module>
from trytond.model import (
ImportError: cannot import name DeactivableMixin
I'm stuck here.
This error is beccause you are mixin some modules of 4.6 series with
modules from 4.8 series.

If you want to test the new version of account_es version on 4.8 series
I have published bitbucket repository which I keep in sync with the
development changes. You can download it from:

https://bitbucket.org/pokoli/account_es/

Hope it helps.
--
Sergi Almacellas Abellana
www.koolpi.com
Twitter: @pokoli_srk
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/3b12067b-97aa-3cf8-a760-5bfde3a9b267%40koolpi.com.
Esteve Boix
2018-05-02 08:06:30 UTC
Permalink
Hi Sergi,

Thanks for your reply.

In fact, I suspect that the module that is giving the problems is indeed
account_es, since it remains at 4.6 as there is no 4.8 version available in
PIP.
As I understand, there is no way to remove it before the upgrade.
I'll give a go at the new test version.

Best regards,
Esteve
Post by Esteve Boix
Post by Esteve Boix
I understand that if I have 4.6.0 installed with this module, I cannot
upgrade (easily) to 4.8.0, am I right ?
Well, you can upgrade without problems but all the taxes and accounts
that are removed on newer versions will not be removed from your
existing database. Otherwise everything works as expected.
Post by Esteve Boix
I've tried the upgrade, but it clashes while doing the database update.
I understand that this happens because Tryton is using functionality that
is not present in 4.6's implementation of es ES chart of accounts module.>
Post by Esteve Boix
I'm not in production. This is just a test server to check if Tryton can
fulfill our needs.
Post by Esteve Boix
ALTER TABLE ir_lang ADD parent VARCHAR;
(as root)
pip install tryton trytond trytond-account trytond-account-eu
trytond-account-invoice trytond-account-invoice-stock
trytond-account-product trytond-company trytond-company-work-time
trytond-country trytond-currency trytond-party trytond-product
trytond-product-attribute trytond-product-price-list trytond-production
trytond-production-routing trytond-production-work trytond-production-work-timesheet
trytond-purchase trytond-sale trytond-sale-extra trytond-sale-opportunity
trytond-sale-price-list trytond-stock trytond-timesheet --upgrade
Post by Esteve Boix
...all fine and succesfully updated.
trytond-admin -c tryton/tryton.conf -d tryton --all
File "/usr/local/bin/trytond-admin", line 21, in <module>
admin.run(options)
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/admin.py",
line 54, in run
Post by Esteve Boix
installdeps=options.installdeps)
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/pool.py",
line 144, in init
Post by Esteve Boix
self.start()
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/pool.py",
line 97, in start
Post by Esteve Boix
register_classes()
File "/home/esteve/.local/lib/python2.7/site-packages/trytond/modules/__init__.py",
line 373, in register_classes
Post by Esteve Boix
mod_file, pathname, description)
File "/usr/local/lib/python2.7/dist-packages/trytond/modules/currency/__init__.py",
line 5, in <module>
Post by Esteve Boix
from .currency import *
File "/usr/local/lib/python2.7/dist-packages/trytond/modules/currency/currency.py",
line 11, in <module>
Post by Esteve Boix
from trytond.model import (
ImportError: cannot import name DeactivableMixin
I'm stuck here.
This error is beccause you are mixin some modules of 4.6 series with
modules from 4.8 series.
If you want to test the new version of account_es version on 4.8 series
I have published bitbucket repository which I keep in sync with the
https://bitbucket.org/pokoli/account_es/
Hope it helps.
--
Sergi Almacellas Abellana
www.koolpi.com
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/
msgid/tryton/3b12067b-97aa-3cf8-a760-5bfde3a9b267%40koolpi.com.
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/CAE1DqQMrKRDw-jVwcoPR3Z2b0TC0xeZjzWFGXe3Br_M0U010OQ%40mail.gmail.com.
Sergi Almacellas Abellana
2018-05-03 12:01:04 UTC
Permalink
Post by Esteve Boix
Hi Sergi,
Thanks for your reply.
In fact, I suspect that the module that is giving the problems is indeed
account_es, since it remains at 4.6 as there is no 4.8 version available
in PIP.
Yes probably. The problem is that it requires trytond 4.6, which is
incompatbile with other modules in 4.8 series.
Post by Esteve Boix
As I understand, there is no way to remove it before the upgrade.
Yes you can uninstall it with:

pip uninstall trytond_account_es
Post by Esteve Boix
I'll give a go at the new test version.
Will be great to have your feedback about the new version :)
--
Sergi Almacellas Abellana
www.koolpi.com
Twitter: @pokoli_srk
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/2edc774a-bd95-4c58-28ee-f5a6b5e79de5%40koolpi.com.
Esteve Boix
2018-05-04 08:24:41 UTC
Permalink
Hi,

Ok, now I feel officially stupid. I thought that uninstalling a module was
more convolved. It seems that just pip uninstall will do. Thanks.

I'll take a look at the new account-es module and will ping you back,

Thanks a lot for your help,
Esteve
Post by Sergi Almacellas Abellana
Post by Esteve Boix
Hi Sergi,
Thanks for your reply.
In fact, I suspect that the module that is giving the problems is indeed
account_es, since it remains at 4.6 as there is no 4.8 version available
in PIP.
Yes probably. The problem is that it requires trytond 4.6, which is
incompatbile with other modules in 4.8 series.
Post by Esteve Boix
As I understand, there is no way to remove it before the upgrade.
pip uninstall trytond_account_es
Post by Esteve Boix
I'll give a go at the new test version.
Will be great to have your feedback about the new version :)
--
Sergi Almacellas Abellana
www.koolpi.com
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/
msgid/tryton/2edc774a-bd95-4c58-28ee-f5a6b5e79de5%40koolpi.com.
--
You received this message because you are subscribed to the Google Groups "tryton" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/tryton/CAE1DqQNy1Fyekc4vqVvJqF95X66R8qse0_wmFY8ZRxgcu_31yg%40mail.gmail.com.
Loading...